[IMP] account,l10n_tr,l10n_tr_nilvera_einvoice: TR codes via additional_identifiers#262960
Draft
adns-odoo wants to merge 1 commit intoodoo:masterfrom
Conversation
Contributor
|
|
…al_identifiers Turkish official codes (Mersis Number, Trade Registry Number, Branch Number) were stored as contact tags (res.partner.category) as a workaround before Odoo's standard additional_identifiers field was available. Now that the field exists, using it keeps the implementation consistent with other localizations and removes the need for custom lookup logic. task-5175991
9783eb7 to
67e3347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Turkish official codes (Mersis Number, Trade Registry Number, Branch Number) had no dedicated field and were stored as contact tags (res.partner.category) as a workaround before Odoo's standard additional_identifiers field was available.
Current behavior before PR:
Official codes are stored as child contact tags under parent categories MERSISNO, TICARETSICILNO, and SUBENO, requiring custom lookup logic in XML generation and send validation.
Desired behavior after PR is merged:
Codes are stored in the standard additional_identifiers JSON field on res.partner under TR_MERSIS, TR_TICARET_SICIL, and TR_SUBE, consistent with how other localizations handle country-specific identifiers.
task-5175991
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr