native/macos: Added support for CursorIcon::NESWResize and CursorIcon::NWSEResize#625
Open
Pewnack wants to merge 1 commit intonot-fl3:masterfrom
Open
native/macos: Added support for CursorIcon::NESWResize and CursorIcon::NWSEResize#625Pewnack wants to merge 1 commit intonot-fl3:masterfrom
Pewnack wants to merge 1 commit intonot-fl3:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS cursor icons CursorIcon::NESWResize and CursorIcon::NWSEResize were not supported. Added support for it.
These cursor icons are not officially supported, but there is an undocumented API for it.
The code for it was basically already there. In apple_util.rs there already is a function load_undocumented_cursor. This function was not entirely correct though and caused a panic. It needed only a small change to make it work. It now tries to set the undocumented cursor and falls back to the default cursor if it doesn't exist.
Cursor icons can be tested with miniquad example program mouse_cursor:
Press keys q to set NESWResize or w to set the NWSEResize icon.
Closes not-fl3/macroquad#1030