Open
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
be4138f to
d6abdf6
Compare
Member
|
Should - setGlobalDispatcher(new EnvHttpProxyAgent())
+ setGlobalDispatcher(new EnvHttpProxyAgent({ proxyTunnel: true })) |
metcoder95
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5093
Rationale
EnvHttpProxyAgentcurrently inheritsProxyAgent's tunneling behavior. For plain HTTP targets reached through an HTTP proxy, defaulting to CONNECT can break proxies that do not implement tunneling and can lead to the looping behavior reported in #5093.Changes
ProxyAgentproxyTunnel: trueas an explicit overrideEnvHttpProxyAgentusinghttp_proxyFeatures
N/A
Bug Fixes
EnvHttpProxyAgentcase behind Use of HTTP_PROXY & NODE_USE_ENV_PROXY fails with an infinite loop #5093 by avoiding CONNECT for that setup unless explicitly requestedBreaking Changes and Deprecations
None
Status