Skip to content

R code improvements from SISMID#584

Merged
sbfnk merged 4 commits intomainfrom
r-code-improvements-578
Dec 2, 2025
Merged

R code improvements from SISMID#584
sbfnk merged 4 commits intomainfrom
r-code-improvements-578

Conversation

@sbfnk
Copy link
Copy Markdown
Contributor

@sbfnk sbfnk commented Dec 2, 2025

Summary

  • Make add_delays() more flexible with customizable distribution functions and parameters
  • Fix Stan array[] syntax matching in nfidd-stan-tools.r for Stan 2.26+
  • Add save_warmup parameter to nfidd_sample()

Closes #578

sbfnk and others added 3 commits December 2, 2025 11:41
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Comment thread R/nfidd-stan-tools.r Outdated
Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wild. I see some linting issues but those may be common across code bases.

@sbfnk
Copy link
Copy Markdown
Contributor Author

sbfnk commented Dec 2, 2025

I've simplified the regex

@sbfnk sbfnk added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 1556ea5 Dec 2, 2025
8 checks passed
@sbfnk sbfnk deleted the r-code-improvements-578 branch December 2, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring in R code changes from SISMID

2 participants